[ 
https://issues.apache.org/jira/browse/LUCENE-9632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244823#comment-17244823
 ] 

Michael Sokolov commented on LUCENE-9632:
-----------------------------------------

I just found a new use for IntroSorter - please don't remove! As for the util 
methods, they're not doing any harm? I'd be -0  to migrate JDK impl for those 
cases where we can; I mean sure, why not, but on the other hand if it's not 
broke, why fix it? The test coverage is a benefit, although we could always 
find another way, but like Uwe points out, we wouldn't really be saving any 
maintenance costs, since we still need to maintain the core algorithm for the 
parallel sorting case.

> Replace our TimSort with JDK TimSort
> ------------------------------------
>
>                 Key: LUCENE-9632
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9632
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: master (9.0)
>            Reporter: Mike Drob
>            Priority: Major
>
> JDK 11 has a TimSort with very similar lineage to our TimSort (written by 
> Josh Bloch, based on Tim Peter's python list sort), we should consider 
> replacing our fork with a version that we don't have to maintain.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to