madrob commented on a change in pull request #2115:
URL: https://github.com/apache/lucene-solr/pull/2115#discussion_r534482769
##########
File path:
solr/core/src/test/org/apache/solr/cloud/TestPullReplicaErrorHandling.java
##########
@@ -236,8 +237,9 @@ public void testCloseHooksDeletedOnReconnect() throws
Exception {
JettySolrRunner jetty =
getJettyForReplica(s.getReplicas(EnumSet.of(Replica.Type.PULL)).get(0));
SolrCore core = jetty.getCoreContainer().getCores().iterator().next();
- for (int i = 0; i < 5; i++) {
+ for (int i = 0; i < (TEST_NIGHTLY ? 5 : 2); i++) {
cluster.expireZkSession(jetty);
+ waitForState("Expecting node to be disconnected", collectionName,
activeReplicaCount(1, 0, 0));
Review comment:
There is a window where live node has gone away but state is still
active because it hasn't updated yet. if we're just waiting for and watching
live nodes, then we can see that go away and complete the test before the
cluster has quiesced. this is also how we check in
testPullReplicaDisconnectsFromZooKeeper, so for consistency this felt better.
There is still a different race here that the replica could go down and come
back up before we start waiting for it to be down the first time (we're
expecting the overseer to be slow), which I'm sure @markrmiller would be upset
with me over, but we can deal with that when he finishes the rest of his speed
up branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
