mikemccand commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-736781955
> I am not sure we can guarantee anything on an OOM? Yeah I suppose that is essentially nearly hopeless, sigh -- this is why `IndexWriter` aborts on OOME. > The explanation from @msfroh is correct here we basically stop the world here since we hold the IW lock, lock all DWPT, prevent the creation of new DWPT and abort all merges. That's basically all we can do here. +1 > I made the ask for removing this method a couple of times since it creates a ton of friction and is hard to test. IMO we should rather ask the user to close the IW, open a new one that re-creates the index altogether. I think this method serves an important purpose/use-case: it lets you efficiently clear the whole index, transactionally, so that e.g. searchers can see the old index, and then the new index, without seeing the fully deleted index at all. I think we should fix its bugs instead! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
