s1monw commented on pull request #2088: URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-736559445
> Well, that is spooky -- this looks like a pre-existing bug in IndexWriter's abort! But I don't think we must fix that before committing this fix? Can you open a new issue for it? I am not sure we can guarantee anything on an OOM? > I'm suspicious that this is safe to do. What if another thread is calling addDocument at the same time? The explanation from @msfroh is correct here we basically stop the world here since we hold the IW lock, lock all DWPT, prevent the creation of new DWPT and abort all merges. That's basically all we can do here. I made the ask for removing this method a couple of times since it creates a ton of friction and is hard to test. IMO we should rather ask the user to close the IW, open a new one that re-creates the index altogether. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
