cpoerschke commented on a change in pull request #1571: URL: https://github.com/apache/lucene-solr/pull/1571#discussion_r518035475
########## File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRInterleavingRescorer.java ########## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.ltr; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; + +import org.apache.lucene.index.LeafReaderContext; +import org.apache.lucene.search.Explanation; +import org.apache.lucene.search.IndexSearcher; +import org.apache.lucene.search.ScoreDoc; +import org.apache.lucene.search.ScoreMode; +import org.apache.lucene.search.TopDocs; +import org.apache.solr.ltr.interleaving.Interleaving; +import org.apache.solr.ltr.interleaving.InterleavingResult; +import org.apache.solr.ltr.interleaving.TeamDraftInterleaving; + +import static org.apache.solr.ltr.search.LTRQParserPlugin.isOriginalRanking; + +/** + * Implements the rescoring logic. The top documents returned by solr with their + * original scores, will be processed by a {@link LTRScoringQuery} that will assign a + * new score to each document. The top documents will be resorted based on the + * new score. + * */ +public class LTRInterleavingRescorer extends LTRRescorer { + + LTRScoringQuery[] rerankingQueries; + Interleaving interleavingAlgorithm = new TeamDraftInterleaving(); + + public LTRInterleavingRescorer(LTRScoringQuery[] rerankingQueries) { + this.rerankingQueries = rerankingQueries; + } + + /** + * rescores the documents: + * + * @param searcher + * current IndexSearcher + * @param firstPassTopDocs + * documents to rerank; + * @param topN + * documents to return; + */ + @Override + public TopDocs rescore(IndexSearcher searcher, TopDocs firstPassTopDocs, + int topN) throws IOException { + if ((topN == 0) || (firstPassTopDocs.scoreDocs.length == 0)) { + return firstPassTopDocs; + } + + int originalRankingIndex = -1; Review comment: 10/n suggestions: * calculate originalRankingIndex in the constructor * use originalRankingIndex to minimise "rerankingQueries[i] is not original ranking" checks * use originalRankingIndex to remove the "original ranking query is always the last query" assumption * the 'rerank' method already takes a `searcher` and so it could determine its own `leaves` from that https://github.com/cpoerschke/lucene-solr/commit/002c31cceaeff411ad35111f00b7cee71c5b11de ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
