mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517895258
##########
File path:
lucene/misc/src/test/org/apache/lucene/misc/index/TestIndexSplitter.java
##########
@@ -60,9 +67,9 @@ public void test() throws Exception {
iw.addDocument(doc);
}
iw.commit();
- DirectoryReader iwReader = iw.getReader();
- assertEquals(3, iwReader.leaves().size());
- iwReader.close();
+ //DirectoryReader iwReader = iw.getReader();
+ //assertEquals(3, iwReader.leaves().size());
+ //iwReader.close();
Review comment:
IndexWriter.getReader() is package-private so it cannot be accessed from
here. It would be better that we omit this assertion (it seems these lines are
not the main part of the test anyway), instead of opening IW.getReader() up to
public?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
