mocobeta commented on a change in pull request #2064:
URL: https://github.com/apache/lucene-solr/pull/2064#discussion_r517888111



##########
File path: lucene/misc/src/java/org/apache/lucene/misc/index/IndexSplitter.java
##########
@@ -123,8 +118,8 @@ private SegmentCommitInfo getInfo(String name) {
 
   public void remove(String[] segs) throws IOException {
     for (String n : segs) {
-      int idx = getIdx(n);
-      infos.remove(idx);
+      SegmentCommitInfo info = getInfo(n);
+      infos.remove(info);

Review comment:
       SegmentInfos.remove(int) isn't accessible from external packages. This 
method call can be switched to SegmentInfo.remove(SegmentCommitInfo); that is 
already opened to public.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to