[
https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223427#comment-17223427
]
Tim Dillon edited comment on SOLR-14034 at 11/4/20, 8:16 AM:
-------------------------------------------------------------
[~marcussorealheis] I see it has been a while since there was any activity on
this, is it still available to work on? I'm new here as well and this seems
like a good place to get started.
So I was looking at this and found something I'm not sure about. There's two
methods that take minRf as a parameter, sendDocs and sendDocsWithRetry (linked
below), that are called in ReplicationFactorTest.java multiple times.
*
[https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L462]
*
[https://github.com/apache/lucene-solr/blob/master/solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java#L938]
However, I also found calls to these methods that pass expectedRf and
expectedRfDBQ instead of minRf.
*
[https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L417]
*
[https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L427]
*
[https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/cloud/ReplicationFactorTest.java#L230]
Is it necessary to pass expectedRf to these methods? The tests still passed
after refactoring the two methods and removing the minRf/expectedRf parameters,
but I'm not sure if that would invalidate these tests or not.
If it is indeed necessary to pass the expectedRf parameters, should I leave
these methods as is? Or would it make sense to create overloaded methods to
handle the few calls with the additional expectedRf parameter?
Sorry for all the questions, just wanted to make sure I'm removing _all_
references to minRf without causing problems elsewhere.
was (Author: trdillon):
[~marcussorealheis] I see it has been a while since there was any activity on
this, is it still available to work on? I'm new here as well and this seems
like a good place to get started.
> remove deprecated min_rf references
> -----------------------------------
>
> Key: SOLR-14034
> URL: https://issues.apache.org/jira/browse/SOLR-14034
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Priority: Blocker
> Labels: newdev
> Fix For: master (9.0)
>
>
> * {{min_rf}} support was added under SOLR-5468 in version 4.9
> (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.9.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L50)
> and deprecated under SOLR-12767 in version 7.6
> (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.6.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L57-L61)
> * http://lucene.apache.org/solr/7_6_0/changes/Changes.html and
> https://lucene.apache.org/solr/guide/8_0/major-changes-in-solr-8.html#solr-7-6
> both clearly mention the deprecation
> This ticket is to fully remove {{min_rf}} references in code, tests and
> documentation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
