[ 
https://issues.apache.org/jira/browse/SOLR-14034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17249836#comment-17249836
 ] 

Christine Poerschke edited comment on SOLR-14034 at 12/15/20, 6:19 PM:
-----------------------------------------------------------------------

Hello everyone.

I'm not very familiar with the {{min_rf}} parameter and what exactly its 
removal here will entail but yes based on 
[https://github.com/apache/lucene-solr/search?q=min_rf] and 
[https://github.com/apache/lucene-solr/search?q=MIN_REPFACT] search results 
this JIRA item remains available to be worked on further – thanks to everyone 
who already started analysing the code as per above.

Perhaps a _draft_ and _initially partially scoped_ pull request could provide a 
way to continue to move forward here i.e. if the SOLR-14034 ticket number is 
included in its title then it will get automatically linked here i.e. we can 
all easily find it then and perhaps then incrementally the possibilities for 
the above questions would become clearer?

Hope that helps.


was (Author: cpoerschke):
Hello everyone.

I'm not very familiar with the {{min_rf}} parameter and what exactly its 
removal here will entail but yes based on 
[https://github.com/apache/lucene-solr/search?q=min_rf] and 
[https://github.com/apache/lucene-solr/search?q=MIN_REPFACT] search results 
this JIRA item remains available to be worked on.

Perhaps a _draft_ and _initially partially scoped_ pull request provide a way 
forward here i.e. if the SOLR-14034 ticket number is included in its title then 
it will get automatically linked here i.e. we can all easily find it then and 
perhaps then incrementally the possibilities for the above questions would 
become clearer?

Hope that helps.

> remove deprecated min_rf references
> -----------------------------------
>
>                 Key: SOLR-14034
>                 URL: https://issues.apache.org/jira/browse/SOLR-14034
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Priority: Blocker
>              Labels: newdev
>             Fix For: master (9.0)
>
>
> * {{min_rf}} support was added under SOLR-5468 in version 4.9 
> (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/4.9.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L50)
>  and deprecated under SOLR-12767 in version 7.6 
> (https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.6.0/solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java#L57-L61)
> * http://lucene.apache.org/solr/7_6_0/changes/Changes.html and 
> https://lucene.apache.org/solr/guide/8_0/major-changes-in-solr-8.html#solr-7-6
>  both clearly mention the deprecation
> This ticket is to fully remove {{min_rf}} references in code, tests and 
> documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to