HoustonPutman commented on a change in pull request #2038:
URL: https://github.com/apache/lucene-solr/pull/2038#discussion_r514545969
##########
File path: solr/contrib/prometheus-exporter/bin/solr-exporter
##########
@@ -135,15 +134,42 @@ if $cygwin; then
[ -n "$REPO" ] && REPO=`cygpath --path --windows "$REPO"`
fi
+# Convert Environment Variables to Command Line Options
+EXPORTER_ARGS=()
+
+if [[ -n "$CONFIG_FILE" ]]; then
+ EXPORTER_ARGS+=(-f "$CONFIG_FILE")
+fi
+
+if [[ -n "$PORT" ]]; then
Review comment:
Yeah, that could certainly happen. `EXPORTER_PORT` would work perfectly
fine. I went the direction decided in
https://github.com/apache/lucene-solr/pull/887 on variable naming. I don't have
a strong opinion either way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
