madrob commented on a change in pull request #2004:
URL: https://github.com/apache/lucene-solr/pull/2004#discussion_r508733802
##########
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##########
@@ -653,7 +653,12 @@ public void close() {
customThreadPool.submit(() ->
Collections.singleton(overseer).parallelStream().forEach(IOUtils::closeQuietly));
Review comment:
While we're here, this line (and a few others) should be
`customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea
why we're creating a collection and a stream for a single object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
