madrob commented on a change in pull request #2004:
URL: https://github.com/apache/lucene-solr/pull/2004#discussion_r508587767
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -38,10 +38,7 @@
import java.util.Properties;
import java.util.Set;
import java.util.UUID;
-import java.util.concurrent.ConcurrentHashMap;
-import java.util.concurrent.ExecutionException;
-import java.util.concurrent.ExecutorService;
-import java.util.concurrent.Future;
+import java.util.concurrent.*;
Review comment:
Please check your IDE settings to not collapse imports like this.
##########
File path: solr/core/src/java/org/apache/solr/update/SolrCoreState.java
##########
@@ -86,7 +103,45 @@ public boolean decrefSolrCoreState(IndexWriterCloser
closer) {
}
return close;
}
-
+
+ /**
+ * Pauses all update requests to this core and waits (indefinitely) for all
in-flight
+ * update requests to finish
+ */
+ public void pauseUpdatesAndAwaitInflightRequests() {
+ if (pauseUpdateRequests.compareAndSet(false, true)) {
+ inflightUpdatesCounter.register();
+ inflightUpdatesCounter.arriveAndAwaitAdvance();
+ }
+ }
+
+ /**
+ * Unpauses update requests to this core
+ */
+ public void unpauseUpdates() {
+ this.pauseUpdateRequests.set(false);
+ }
+
+ /**
+ * Registers in-flight update requests to this core.
+ *
+ * @return true if request was registered, false if update requests are
paused
+ */
+ public boolean registerInFlightUpdate() {
+ if (pauseUpdateRequests.get()) {
+ return false;
+ }
+ inflightUpdatesCounter.register();
Review comment:
Maybe `return inflightUpdatesCounter.register() > 0`? Or `>=`, I'm not
sure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
