madrob commented on a change in pull request #1997:
URL: https://github.com/apache/lucene-solr/pull/1997#discussion_r508022496
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -415,19 +415,15 @@ private void fetchIndex(SolrParams solrParams,
SolrQueryResponse rsp) throws Int
}
static Long getCheckSum(Checksum checksum, File f) {
- FileInputStream fis = null;
checksum.reset();
byte[] buffer = new byte[1024 * 1024];
int bytesRead;
- try {
- fis = new FileInputStream(f);
+ try (final FileInputStream fis = new FileInputStream(f)) {
while ((bytesRead = fis.read(buffer)) >= 0)
checksum.update(buffer, 0, bytesRead);
return checksum.getValue();
} catch (Exception e) {
Review comment:
> There are no further references to fis in the code path.
The try-with-resources will generate a synthetic finally block that calls
`fis.close()`. If the call to close throws an Exception, then... I guess we
didn't release it? But in the closeQuietly case, we swallow the exception and
we don't guarantee the close either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
