msokolov commented on pull request #1930: URL: https://github.com/apache/lucene-solr/pull/1930#issuecomment-712104682
@jtibshirani I am in sympathy with your points; the scoring implementations don't really belong in VectorValues which is more of an abstract interface otherwise, and random-access API should really be an internal detail of the HNSW implementation. I did fiddle with ideas for hiding the RandomAccess API but see my comments about visibility in the thread above; I'm not yet sure what the best way is. Probably it will be easiest to address these as part of the HNSW patch, as you say, but if you have specific ideas, please feel free to post a PR! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
