[ https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17209771#comment-17209771 ]
ASF subversion and git services commented on SOLR-14691: -------------------------------------------------------- Commit 969f9c189942f860217005882cba1378c898d22f in lucene-solr's branch refs/heads/master from Andrzej Bialecki [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=969f9c1 ] SOLR-14691: Fix a minor back-compat formatting issue. > Metrics reporting should avoid creating objects > ----------------------------------------------- > > Key: SOLR-14691 > URL: https://issues.apache.org/jira/browse/SOLR-14691 > Project: Solr > Issue Type: Improvement > Components: metrics > Reporter: Andrzej Bialecki > Assignee: Andrzej Bialecki > Priority: Critical > Fix For: 8.7 > > Time Spent: 1.5h > Remaining Estimate: 0h > > {{MetricUtils}} unnecessarily creates a lot of short-lived objects (maps and > lists). This affects GC, especially since metrics are frequently polled by > clients. We should refactor it to use {{MapWriter}} as much as possible. > Alternatively we could provide our wrappers or subclasses of Codahale metrics > that implement {{MapWriter}}, then a lot of complexity in {{MetricUtils}} > wouldn't be needed at all. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org