[
https://issues.apache.org/jira/browse/SOLR-14691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208572#comment-17208572
]
Andrzej Bialecki commented on SOLR-14691:
-----------------------------------------
PR 1951 replaces all use of Map / List in {{MetricUtils}} and also adds similar
improvements to {{MapWriterJSONWriter}} that is used whenever
{{Utils.toJsonString(...)}} is used. If there are no objections I'll commit
this shortly.
> Metrics reporting should avoid creating objects
> -----------------------------------------------
>
> Key: SOLR-14691
> URL: https://issues.apache.org/jira/browse/SOLR-14691
> Project: Solr
> Issue Type: Improvement
> Components: metrics
> Reporter: Andrzej Bialecki
> Assignee: Andrzej Bialecki
> Priority: Critical
> Fix For: 8.7
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{MetricUtils}} unnecessarily creates a lot of short-lived objects (maps and
> lists). This affects GC, especially since metrics are frequently polled by
> clients. We should refactor it to use {{MapWriter}} as much as possible.
> Alternatively we could provide our wrappers or subclasses of Codahale metrics
> that implement {{MapWriter}}, then a lot of complexity in {{MetricUtils}}
> wouldn't be needed at all.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
