dweiss commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-702532515
I'll take a look later today. On Fri, Oct 2, 2020 at 12:02 AM Mike Drob <notificati...@github.com> wrote: > *@madrob* commented on this pull request. > ------------------------------ > > In lucene/packaging/build.gradle > <https://github.com/apache/lucene-solr/pull/1905#discussion_r498535024>: > > > +// This project puts together a "distribution", assembling dependencies from > +// various other projects. > + > +plugins { > + id 'distribution' > +} > + > +description = 'Lucene distribution packaging' > + > +// Declare all subprojects that should be included in binary distribution. > +// By default everything is included, unless explicitly excluded. > +def includeInBinaries = project(":lucene").subprojects.findAll {subproject -> > + return !(subproject.path in [ > + ":lucene:packaging", > + ":lucene:analysis", > + ":lucene:luke", // nocommit - Encountered duplicate path "luke/lib/log4j-core-2.13.2.jar" > > @dweiss <https://github.com/dweiss> this is still a problem, not sure why > it comes up or how to resolve it. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene-solr/pull/1905#pullrequestreview-500748647>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABQWLW5ZDMITGXLCQACWWTSIT4BFANCNFSM4RVC7DPQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
