dweiss commented on pull request #1905: URL: https://github.com/apache/lucene-solr/pull/1905#issuecomment-702369827
I think it looks good now! If there's anything else we can follow-up. On Thu, Oct 1, 2020 at 12:13 AM Mike Drob <notificati...@github.com> wrote: > Dawid, it took me a few tries of going through your comments and other > examples in the code but I think it finally dawned on me what you meant as > the proper way to do it. Each task can export its own outputs as an > artifact, that's the piece that was missing in my mental model. Please take > another look? > > There's another piece where the Luke log4j dependency was causing a > duplicate entry error in the archives... not sure if you were getting the > same error or not. Otherwise the output zip looks pretty close to the real > thing from 8x > > — > You are receiving this because your review was requested. > Reply to this email directly, view it on GitHub > <https://github.com/apache/lucene-solr/pull/1905#issuecomment-701674748>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AABQWLVX43SMOFUVZI3GU6TSIOUSJANCNFSM4RVC7DPQ> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
