mikemccand commented on pull request #1912: URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-700718570
> > We are talking about assigning DWPT to incoming indexing thread, right? > > Right. > > The thing that makes me hesitate is that it would probably make fetching a DWPT slightly more costly, which could slow indexing down with very fast indexing chains like the 1kb wikipedia documents dataset we use for nightly benchmarks since this method is called under a lock. Let's see if benchmarks really notice that? Net/net I think the change is a good idea. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
