jpountz commented on pull request #1912: URL: https://github.com/apache/lucene-solr/pull/1912#issuecomment-703163915
> I am a bit worried about perf impact of this new "best effort" priority queue. Yeah I looked into it because I was worried of the performance impact of a proper priority queue which needs to do non-negligible work on every push/poll to keep the queue ordered. But it's not clear to me how much more costly it is compared to the current approach. I was planning on running another benchmark with a lighter indexing chain to better see the impact of this change, e.g. with doc-value fields only, so that the amount of work that is performed between the time when the DWPT pool is polled and the time when the DWPT is added back to the queue is not much heavier than the action of polling from / pushing to the queue. > I'm curious to see impact on nightly indexing. So am I. :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
