dweiss commented on pull request #1919:
URL: https://github.com/apache/lucene-solr/pull/1919#issuecomment-698564766


   I like the explicit field too, actually - even if you're right about 
capacity of internal blocks, Adrien. - this assertion there may actually be my 
mistake and the capacity of a new block should actually be its limit (remaining 
free space)... Or maybe I did have capacity in mind (can't remember, to be 
honest).
   ```
   currentBlock = blockAllocate.apply(requiredBlockSize);
       assert currentBlock.capacity() == requiredBlockSize;
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to