[ 
https://issues.apache.org/jira/browse/LUCENE-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200042#comment-17200042
 ] 

Dawid Weiss commented on LUCENE-9528:
-------------------------------------

I don't think that grammar in javacc is too bad, to be honest - not after a 
minor cleanup (and me getting used to some javacc concepts). The problem with 
Antlr is that it adds a dependency on its runtime, which kind of sucks. 

I honestly don't care much what it's written in as long as it works. :) 
Parboiled is kind of fun too [1], for example.

[1] https://en.wikipedia.org/wiki/Parboiled_(Java)


> Clean up obsolete and commented-out cruft from StandardSyntaxParser.jj
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-9528
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9528
>             Project: Lucene - Core
>          Issue Type: Sub-task
>            Reporter: Dawid Weiss
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: master (9.0)
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The indentation in that file is crazy. So are micro-optimizations which make 
> reading the syntax parser much more difficult than it actually is.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to