[
https://issues.apache.org/jira/browse/LUCENE-9528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200037#comment-17200037
]
David Smiley commented on LUCENE-9528:
--------------------------------------
What attracted both search projects I was a part of to this design, apart from
me showing it to my clients/employers :-), is the flexible design and
separation of query syntax specification from Lucene Queries. Indeed, that
part is excellent! Both projects ultimately wrote new code for themselves that
borrowed that same winning philosophy, and the choice *not* to use this
flexible query parser was in neither case mine. In both cases, what turned my
peers off from it is its complexity (I recall too many classes, and other
reasons) and age (didn't use new Java language features/techniques and choice
of JavaCC was dubious relative to Antlr), and I sympathize a lot. I haven't
looked at it in years now but I recall having a constant itch to either
simplify it and/or clean it up when looking at the old code, which isn't a good
sign (to me). I was imagining a totally revamped flexible query parser built
on Antlr4.
[~rjernst] maybe you might have some opinions on this given I've seen you work
on 2-3 parsers in Lucene.
> Clean up obsolete and commented-out cruft from StandardSyntaxParser.jj
> ----------------------------------------------------------------------
>
> Key: LUCENE-9528
> URL: https://issues.apache.org/jira/browse/LUCENE-9528
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Dawid Weiss
> Assignee: Dawid Weiss
> Priority: Minor
> Fix For: master (9.0)
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The indentation in that file is crazy. So are micro-optimizations which make
> reading the syntax parser much more difficult than it actually is.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
