dweiss commented on pull request #1836: URL: https://github.com/apache/lucene-solr/pull/1836#issuecomment-696537432
In general, I like it. I wondered whether it'd make sense to create a separate package (subproject) for those classes moved to the core - this would make the core really separate from analysis. If somebody is using dependency systems with transitive dependencies, they wouldn't feel the difference (the analysis-util/ analysis-base?) subprojects would be sucked in automatically. What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
