mocobeta opened a new pull request #1836:
URL: https://github.com/apache/lucene-solr/pull/1836


   This is a draft pull request for review, to try to clean up package name 
conflicts between `analyzers-common` and `core`. Also I tried to make necessary 
changes as small as possible.
   
   See https://issues.apache.org/jira/browse/LUCENE-9317 for more background.
   
   The main changes are:
   
   - Move analysis base classes to lucene-core (o.a.l.a) from analyzers-common 
(o.a.l.a.util)
   - Rename all service provider files (META-INF/services/...).
   - Move o.a.l.a.standard.StandardTokenizer to lucene-core
   - Split o.a.l.a.standard in analyzers-common into o.a.l.a.classic and 
o.a.l.a.email
   
   With above changes, there is no package name conflicts.
   
   - `o.a.l.a.util` and newly created `o.a.l.a.classic` and `o.a.l.a.email` 
only exist in `analyzers-common`
   - `o.a.l.a.standard` only exists in `lucene-core`
   - other packages are not touched.
   
   Compiling whole Lucene/Solr main classes are fine, thanks to IDE's 
refactoring feature.
   
   Tasks to be done:
   
   - Create fake factory base classes in o.a.l.a.util for backward 
compatibility (?)
   - Fix tests
   - Fix gradle scripts (?)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to