[
https://issues.apache.org/jira/browse/SOLR-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197420#comment-17197420
]
Dawid Weiss commented on SOLR-14824:
------------------------------------
This looks weird (and comment is inconsistent with code).
{code}
+ // use ".0" release for linking to javadocs
+ htmlSolrJavadocs =
"https://lucene.apache.org/solr/${solrGuideVersionPath}_0/";
+ htmlLuceneJavadocs =
"https://lucene.apache.org/core/${solrGuideVersionPath}_0/";
{code}
If this draft status is related to version then it could be automatically
detected (version.contains("SNAPSHOT")).
{code}
solrGuideDraftStatus: propertyOrDefault("solrGuideDraft",
"true").toBoolean() ? "DRAFT" : "",
{code}
Overall though I like the simplifications and cleanups. Looks much better to me
than before!
> Simplify set of Ref Guide build parameters
> ------------------------------------------
>
> Key: SOLR-14824
> URL: https://issues.apache.org/jira/browse/SOLR-14824
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build, documentation
> Reporter: Cassandra Targett
> Assignee: Chris M. Hostetter
> Priority: Minor
> Attachments: SOLR-14824.patch, SOLR-14824.patch
>
>
> While trying to solve LUCENE-9495, I thought it might be a good idea to try
> to simplify the set of variables and properties used during the Ref Guide
> build.
> There are 3 areas to work on:
> 1. Remove the "barebones-html" build. With Gradle the build is self-contained
> and {{gradlew check}} and {{gradle precommit}} could just build the full docs
> and check them.
> 2. Remove some properties that only existed for a hypothetical need related
> to the now-removed PDF.
> 3. Change remaining properties to be defined directly in build.gradle instead
> of relying on ant properties functionality.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
