[
https://issues.apache.org/jira/browse/SOLR-14824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197285#comment-17197285
]
Chris M. Hostetter commented on SOLR-14824:
-------------------------------------------
Hmmm.... i don't really feel comfortable trying to tackle those changes
here/now – let's pursue this idea more in SOLR-14870 – because AFAICT those
productDir/buildDir variables return absolute file paths (which will then be
turned into absolute 'file:///' URLs) but that would break the existing link
validation logic we have in the ref-guide because it only checks links to
relative paths ... but i'm assuming we could relativize those paths again the
ref-guides own buildDir? ... either way: let's not muck with them until we
actually get the link checking working again.
(also, FWIW, trying to call {{toURI}} on
{{project(':lucene').buildDir.toPath()}} or
{{project(':lucene').buildDir.toPath().resolve('documentation')}} kept giving
me a weird groovy error i couldn't make heads of tails of: {{No signature of
method: build_16l26jli5s3vhg4xrd8039hq6.ext() is applicable for argument types:
(build_16l26jli5s3vhg4xrd8039hq6$_run_closure6) values:
[build_16l26jli5s3vhg4xrd8039hq6$_run_closure6@c2feddd]}}
> Simplify set of Ref Guide build parameters
> ------------------------------------------
>
> Key: SOLR-14824
> URL: https://issues.apache.org/jira/browse/SOLR-14824
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Build, documentation
> Reporter: Cassandra Targett
> Assignee: Chris M. Hostetter
> Priority: Minor
> Attachments: SOLR-14824.patch, SOLR-14824.patch
>
>
> While trying to solve LUCENE-9495, I thought it might be a good idea to try
> to simplify the set of variables and properties used during the Ref Guide
> build.
> There are 3 areas to work on:
> 1. Remove the "barebones-html" build. With Gradle the build is self-contained
> and {{gradlew check}} and {{gradle precommit}} could just build the full docs
> and check them.
> 2. Remove some properties that only existed for a hypothetical need related
> to the now-removed PDF.
> 3. Change remaining properties to be defined directly in build.gradle instead
> of relying on ant properties functionality.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
