[ https://issues.apache.org/jira/browse/LUCENE-9515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17195256#comment-17195256 ]
ASF subversion and git services commented on LUCENE-9515: --------------------------------------------------------- Commit 4d46caa05d01e6f7e2b3a3b432906eb45732bbfe in lucene-solr's branch refs/heads/master from Simon Willnauer [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4d46caa ] LUCENE-9515: Detach DWPT from DefaultIndexingChain (#1848) This change removes the DWPT dependency from DefaultIndexingChain and rather passes on the primitives needed for creating the chain. > Detach DWPT from DefaultIndexingChain > -------------------------------------- > > Key: LUCENE-9515 > URL: https://issues.apache.org/jira/browse/LUCENE-9515 > Project: Lucene - Core > Issue Type: Improvement > Affects Versions: master (9.0), 8.7 > Reporter: Simon Willnauer > Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > > DefaultIndexingChain or rather its super class DocConsumer is still tightly > coupled to DocumentsWriterPerThread. In oder to guarantee better code > isolation and hopefully independent testing down the road we can expand the > IndexingChain interface to take all the primitives needed rather than the > complex DWPT class. It's unclear anyway how this API (DocConsumer and > IndexingChain) should be implemented with all the classes it depends on being > package private. I will open a follow-up to discuss if we can remove that > abstraction. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org