dsmiley commented on pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-686588314
I am a conflict-avoider (not a good thing) but need to say I fully agree with @sigram 's impression of the tone. I can tell, personally, as a subjective measure in how my own body reacts. When I read conflict, my heart starts racing (fight/flight response?), and it started racing on some of Noble's comments and Ishan alike. It can be hard to objectively measure tone; I think it's fundamentally subjective, though some particulars we point to can be illustrative of behavioral problems. I will be specific: @chatman wrote > Plugin making concurrent requests is "complicated"? Java is hard, but I can help you write a plugin that can make concurrent requests cleanly. Please don't pollute solr-core because of your perceived inability to do so cleanly from a plugin. Wow. I'm not even sure that would be polite to say to a junior engineer (that may be presumed to not know concurrency) than a very senior one here. I think you know full well that Ilan doesn't need your help writing concurrent code. Yet why would you offer help? I think this is a false offer (you know Ilan will not take you up on this); -- it's a pejorative offer that belittles who you offer it to as being beneath the abilities of your own. I wonder why you would say that? Maybe you don't believe it's worth it to make it easier for plugin writers at the expense of Solr having such concurrent code (i.e. where does the concurrency/complexity go) -- fare, but then just say that without belittling anyone's intelligence. At least at the moment it seems we're at a point of better understanding. p.s. This PR is so big/long that my browser (Safari) struggles to keep up as I type here. I copy-paste from a text-editor.t ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
