[
https://issues.apache.org/jira/browse/LUCENE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189027#comment-17189027
]
Dawid Weiss commented on LUCENE-9495:
-------------------------------------
> it's been renamed (probably to be more "gradle-esque" ?) using camel case:
> solrGuideVersion
It's a groovy variable; it'd be pretty awkward (or even impossible) to declare
it with dashes?
> it has to be specified using '-P' (which is evidently the gradle way of
> setting project properties on the command line
Correct. This was early work - we since use a closure propertyOrDefault which
resolves system properties as well as project properties. Could use that
instead to resolve the value.
> A lot of this was spelled out in the build.xml comments, but that info
> evidently wasn't preserved in the creation of build.gradle...
Very likely so. I admit I didn't care much about reading the ant code - all I
cared for the output to be pretty much identical. There are several TODO
entries in that gradle build file where I still felt things could be improved
but had to stick to ant compatibility (or didn't find enough motivation to do
so).
> Ref Guide gradle buildSite ignores version parameter
> ----------------------------------------------------
>
> Key: LUCENE-9495
> URL: https://issues.apache.org/jira/browse/LUCENE-9495
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Reporter: Cassandra Targett
> Priority: Major
>
> All Ref Guide builds by default are built as drafts. A DRAFT watermark is
> inserted on to every page, a special header is added to the side navigation,
> and the footer version includes the word "-DRAFT".
> To accomplish this, the guide has long used a parameter
> {{solr-guide-version}} to indicate when a build for the Ref Guide _should
> not_ be considered a draft. With the Gradle build, this no longer works. (I
> thought I'd tested this, but either I missed it or it broke at some point in
> between.)
> [~hossman] set this up several years ago, so cc'ing him here so he can take a
> look and see why the logic would stop working now.
> Links:
> Ref Guide {{build.gradle}} that determines Guide version:
> https://github.com/apache/lucene-solr/blob/master/solr/solr-ref-guide/build.gradle#L128
> Ant {{build.xml}} the above was adapted from:
> https://github.com/apache/lucene-solr/blob/branch_8x/solr/solr-ref-guide/build.xml#L70
>
> Beyond getting this to work, I think it's worth a discussion (separate Jira?)
> about whether we can simplify it. Maybe just a parameter
> {{ref-guide-draft=false}} would be sufficient? We might also reconsider the
> variations of versions in the Ref Guide params and whether we really need
> them ({{solr-guide-version}}, {{solr-docs-version}}).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
