[ https://issues.apache.org/jira/browse/LUCENE-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182806#comment-17182806 ]
Dawid Weiss edited comment on LUCENE-9474 at 8/23/20, 6:55 PM: --------------------------------------------------------------- I left a few comments on github on this commit, Uwe. I can clean up later; some TODOs are not valid: we can't use jgit to apply that patch - jgit's apply is broken, see my comment here - I did try it: https://github.com/apache/lucene-solr/pull/1262; if you're curious as to why, take a look at this snippet of jgit's apply command: https://github.com/eclipse/jgit/blob/8774f541904ca9afba1786b4da14c1aedf4dda78/org.eclipse.jgit/src/org/eclipse/jgit/api/ApplyCommand.java#L282-L291 was (Author: dweiss): I left a few comments on github on this commit, Uwe. I can clean up later; some TODOs are not valid (we can't use jgit to apply that patch - jgit's apply is broken). > Change Jenkins jobs to use Gradle for trunk > ------------------------------------------- > > Key: LUCENE-9474 > URL: https://issues.apache.org/jira/browse/LUCENE-9474 > Project: Lucene - Core > Issue Type: Test > Components: general/build > Reporter: Erick Erickson > Assignee: Uwe Schindler > Priority: Major > > I rushed the gate and pushed LUCENE-9433 without coordinating, my apologies > for the confusion. > Meanwhile, Uwe has disabled Jenkins jobs for the weekend and we'll fix this > up Real Soon Now. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org