[ 
https://issues.apache.org/jira/browse/SOLR-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182525#comment-17182525
 ] 

Bram Van Dam commented on SOLR-14758:
-------------------------------------

[~mdrob] I've only encountered this in multi-shard situations. I assumed that 
mergeIds() is only called when there are multiple shards at play, though I have 
to admit that I'm mostly ignorant as to how query distribution and result 
merging works. A previous patch (b8d569aff0c4417b0f9cd52d54455ab9b66236a1) by 
[~mkhl] added a catch(ExitableDirectoryReader.ExitingReaderException) clause to 
doFieldSortValues(), which seems like the only place where sort_values is set. 
But I suspect there must be another way to exit that method which doesn't hit 
that particular catch clause. 

I'll try to spend some more time next week to reproduce this in test. But my 
null check seems to have fixed it, and it hasn't caused any regressions in the 
test build we've been running internally for a couple of days, so at the very 
least it didn't make things worse. 

> NPE in QueryComponent.mergeIds when using timeAllowed and sorting
> -----------------------------------------------------------------
>
>                 Key: SOLR-14758
>                 URL: https://issues.apache.org/jira/browse/SOLR-14758
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>    Affects Versions: master (9.0), 7.7.3
>            Reporter: Bram Van Dam
>            Priority: Major
>         Attachments: SOLR-14758.patch, SOLR-14758.patch
>
>
> Only tested on 7.7.3 and master, but the offending code hasn't been changed 
> for a while, so this presumably affects other versions as well. 
> Steps to reproduce:
> # SolrCloud
> # Create a query which is complex enough to take a while
> # Add a sort clause to the query (e.g. &sort=creationTimestamp asc)
> # Add a short value timeAllowed (10ms in my test)
> Result: NPE in QueryComponent.mergeIds:935
> It may take a couple of attempts to hit the error.
> Offending code:
> {code:java}
>         NamedList sortFieldValues = 
> (NamedList)(srsp.getSolrResponse().getResponse().get("sort_values"));
>         if (sortFieldValues.size()==0 && // we bypass merging this response 
> only if it's partial itself
>                             thisResponseIsPartial) { // but not the previous 
> one!!
>           continue; //fsv timeout yields empty sort_vlaues
>         }
> {code}
> sortFieldValues can apparently be null in some cases, depending on when the 
> query hits the timeAllowed. Adding an extra null check fixes the issue.
> {code:java}
>         NamedList sortFieldValues = 
> (NamedList)(srsp.getSolrResponse().getResponse().get("sort_values"));
>         if ((null == sortFieldValues || sortFieldValues.size()==0) && // we 
> bypass merging this response only if it's partial itself
>                             thisResponseIsPartial) { // but not the previous 
> one!!
>           continue; //fsv timeout yields empty sort_vlaues
>         }
> {code}
> I'll attach a patch.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to