[ 
https://issues.apache.org/jira/browse/SOLR-14641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17174244#comment-17174244
 ] 

Ishan Chattopadhyaya commented on SOLR-14641:
---------------------------------------------

bq. But that quite non-sense to me from the point of who did the commit to do 
performance test
I disagree. In general, whoever wishes to introduce a change should own the 
performance testing, no matter who actually does it. Others can volunteer, but 
ultimate obligation should remain with the committer introducing the change.

bq. this change just basically remove deprecated code rather than optimization. 
If you are *confident* this is just dead code removal, please feel free to go 
ahead _with this one_. Thanks for the clarification!

> PeerSync, remove canHandleVersionRanges check
> ---------------------------------------------
>
>                 Key: SOLR-14641
>                 URL: https://issues.apache.org/jira/browse/SOLR-14641
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Cao Manh Dat
>            Assignee: Cao Manh Dat
>            Priority: Major
>             Fix For: 8.7
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> SOLR-9207 introduces PeerSync with updates range which committed in 6.2 and 
> 7.0. To maintain backward compatibility at the time we introduce an endpoint 
> in RealTimeGetComponent to check whether a node support that feature or not. 
> It served well its purpose and it should be removed to reduce complexity and 
> a request-response trip for asking that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to