tflobbe commented on a change in pull request #1602:
URL: https://github.com/apache/lucene-solr/pull/1602#discussion_r466603545
##########
File path: solr/core/src/test/org/apache/solr/update/SolrIndexConfigTest.java
##########
@@ -208,4 +210,16 @@ public void testToMap() throws Exception {
assertEquals(mSizeExpected, m.size());
}
+
+ public void testMaxCommitMergeWaitSeconds() throws Exception {
+ SolrConfig sc = new SolrConfig(TEST_PATH().resolve("collection1"),
"solrconfig-test-misc.xml");
+ assertEquals(-1, sc.indexConfig.maxCommitMergeWaitMillis);
+ assertEquals(IndexWriterConfig.DEFAULT_MAX_COMMIT_MERGE_WAIT_MILLIS,
sc.indexConfig.toIndexWriterConfig(h.getCore()).getMaxCommitMergeWaitMillis());
+ System.setProperty("solr.tests.maxCommitMergeWait", "10");
+ sc = new SolrConfig(TEST_PATH().resolve("collection1"),
"solrconfig-test-misc.xml");
+ assertEquals(10, sc.indexConfig.maxCommitMergeWaitMillis);
+ assertEquals(10,
sc.indexConfig.toIndexWriterConfig(h.getCore()).getMaxCommitMergeWaitMillis());
+ System.clearProperty("solr.tests.maxCommitMergeWait");
Review comment:
Yes, I checked. I believe the cleanup is after the class. I discussed
with @madrob, and I'll move the cleanup to a `tearDown()` method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
