tflobbe commented on a change in pull request #1602:
URL: https://github.com/apache/lucene-solr/pull/1602#discussion_r466565653
##########
File path: solr/core/src/java/org/apache/solr/update/SolrIndexConfig.java
##########
@@ -129,8 +143,9 @@ public SolrIndexConfig(SolrConfig solrConfig, String
prefix, SolrIndexConfig def
true);
useCompoundFile = solrConfig.getBool(prefix+"/useCompoundFile",
def.useCompoundFile);
-
maxBufferedDocs=solrConfig.getInt(prefix+"/maxBufferedDocs",def.maxBufferedDocs);
+ maxBufferedDocs = solrConfig.getInt(prefix+"/maxBufferedDocs",
def.maxBufferedDocs);
ramBufferSizeMB = solrConfig.getDouble(prefix+"/ramBufferSizeMB",
def.ramBufferSizeMB);
+ maxCommitMergeWaitMillis = solrConfig.getInt(prefix+"/maxCommitMergeWait",
def.maxCommitMergeWaitMillis);
Review comment:
I had it with `MIllis` and I removed that because I didn't see anything
else in the solrconfig that included the unit for time (it's always
milliseconds). You are suggesting `maxCommitMergeWait` or `maxCommitMergeTime`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
