MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464732631
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
numberBackupsToKeep = 0;
}
@SuppressWarnings({"rawtypes"})
- NamedList slave = (NamedList) initArgs.get("slave");
- boolean enableSlave = isEnabled( slave );
- if (enableSlave) {
- currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave,
this, core);
- setupPolling((String) slave.get(POLL_INTERVAL));
- isSlave = true;
+ NamedList secondary = (NamedList) initArgs.get("secondary");
+ boolean enableSecondary = isEnabled( secondary );
+ if (enableSecondary) {
+ currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary,
this, core);
+ setupPolling((String) secondary.get(POLL_INTERVAL));
+ isSecondary = true;
}
@SuppressWarnings({"rawtypes"})
- NamedList master = (NamedList) initArgs.get("master");
- boolean enableMaster = isEnabled( master );
+ NamedList primary = (NamedList) initArgs.get("primary");
Review comment:
> > except for the backcompat issue (which I don't think matters at all).
>
> What's the real issue? Let's accept as input "master" or "primary" in one
case and "slave" or "secondary" in the other, as well as send both values over
the wire as output.
> This will make new code and old code compatible (old talking to new and
new talking to old). Once only new code is running, we can safely remove
sending or accepting the offending terms.
The real issue here is that the terms should've been removed years ago, or
never used. They are super stressful to interact with and every time I combed
through my changes here it was really frustrating. I was in college when the
project was released. These terms were not used at Grinnell College. I could
give a history lesson if you'd like to understand, but I think we should align
with the standards put forth by the IETF and expressed in the Apache Code of
Conduct at a minimum. We should also remember to prioritize community over
code. We shouldn't even be looking to preserve rolling upgrades in favor of
keeping such stressful nomenclature. There's so much changing in 9 already that
is backward incompatible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]