chatman commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464420903
##########
File path: solr/core/src/java/org/apache/solr/handler/ReplicationHandler.java
##########
@@ -1241,33 +1241,33 @@ public void inform(SolrCore core) {
numberBackupsToKeep = 0;
}
@SuppressWarnings({"rawtypes"})
- NamedList slave = (NamedList) initArgs.get("slave");
- boolean enableSlave = isEnabled( slave );
- if (enableSlave) {
- currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(slave,
this, core);
- setupPolling((String) slave.get(POLL_INTERVAL));
- isSlave = true;
+ NamedList secondary = (NamedList) initArgs.get("secondary");
+ boolean enableSecondary = isEnabled( secondary );
+ if (enableSecondary) {
+ currentIndexFetcher = pollingIndexFetcher = new IndexFetcher(secondary,
this, core);
+ setupPolling((String) secondary.get(POLL_INTERVAL));
+ isSecondary = true;
}
@SuppressWarnings({"rawtypes"})
- NamedList master = (NamedList) initArgs.get("master");
- boolean enableMaster = isEnabled( master );
+ NamedList primary = (NamedList) initArgs.get("primary");
Review comment:
> I hope that is clearly documented somewhere? The only refguide page I
could find on upgrading is the rolling one :)
If not documented, it should be. It has never been supported explicitly.
> Btw - since when was the size of a PR a good reason for rushing it into
the codebase?
Hahah ;-) Ever since you displayed intent to sabotage/stall this effort (by
requesting Marcus to go back to the solr-user list and discussing it there) :-)
Anyway, jokes aside, this PR is quite close to being ready, except for the
backcompat issue (which I don't think matters at all).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]