murblanc commented on pull request #1694: URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664240038
I see two cases where we need interfaces such as defined here: - internal code. Coding to interfaces rather than the actual implementation makes for better structured code usually with less implementation leaks, - external “plugins”. What’s the intention? If only the later, then there’s really no need to have the internal classes implement these interfaces, a wrapper is ok. I believe addressing both points with a single interface is complicated (and to a point counterproductive as it ties internal and external views). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
