murblanc commented on pull request #1694: URL: https://github.com/apache/lucene-solr/pull/1694#issuecomment-664230886
Many methods returning other objects are returning names of other abstractions being defined here (Shard, Collection, Node etc.). I’d think an instance of the abstraction should be returned instead, and that instance would have a getName() method (i.e have SolrCollection getCollection() rather than String getCollection() on a Shard for example). What’s the rationale for returning names rather than objects? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
