murblanc commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r458233991
########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/PropertyKeyFactory.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * Factory used by the plugin to create property keys to request property values from Solr + */ +public interface PropertyKeyFactory { + /** + * Returns a property key allowing to request the number of cores. There are no parameters for this key. + */ + CoresCountPropertyKey createCoreCountKey(); + + /** + * Returns a property key allowing to request the value of a system property (sorry property used twice in two different + * contexts). The parameter is the name of the system property to retrieve. + */ + SystemPropertyPropertyKey createSystemPropertyKey(String systemPropertyName); Review comment: Sure, this is just the very initial drop to show the overall approach. By no means complete! Actually I'll go through all the Collection API commands as well as the Autoscaling tests to see what was used and needs to be added to these interfaces. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
