sigram commented on a change in pull request #1684: URL: https://github.com/apache/lucene-solr/pull/1684#discussion_r458109976
########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/Replica.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * An instantiation (or one of the copies) of a given {@link Shard} of a given {@link SolrCollection}. + * Objects of this type are returned by the Solr framework to the plugin, they are not built by the plugin. When the + * plugin wants to add a replica it goes through {@link WorkOrderFactory#createWorkOrderCreateReplica}). + * TODO is there an elegant way to have this type also used by the plugin to add replicas? (insisting on elegant) + */ +public interface Replica { + Shard getShard(); + + ReplicaType getType(); Review comment: We probably need ReplicaState here too, otherwise it will be difficult to determine when movements are needed. ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/PropertyKeyFactory.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * Factory used by the plugin to create property keys to request property values from Solr + */ +public interface PropertyKeyFactory { + /** + * Returns a property key allowing to request the number of cores. There are no parameters for this key. + */ + CoresCountPropertyKey createCoreCountKey(); + + /** + * Returns a property key allowing to request the value of a system property (sorry property used twice in two different + * contexts). The parameter is the name of the system property to retrieve. + */ + SystemPropertyPropertyKey createSystemPropertyKey(String systemPropertyName); Review comment: We also need several node-level metrics, so maybe add a MetricsPropertyKey? ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/CreateCollectionRequest.java ########## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +/** + * <p>Request for creating a new collection with a given number of shards and replication factor for various replica types.</p> + * + * Note there is no need at this stage to allow the request to convey each shard hash range for example, this can be handled + * by the Solr side implementation without needing the plugin to worry about it. + * + */ +public interface CreateCollectionRequest extends Request { + String getCollectionName(); + + int getShardCount(); Review comment: Users must be able to request specific shard names, not just the count, eg. when implicit router is used. Other parameters are needed too, such as the router parameters, non-default shard hash ranges etc. See CollectionAdminRequest for details. ########## File path: solr/core/src/java/org/apache/solr/cloud/gumi/Shard.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.cloud.gumi; + +import java.util.Set; + +/** + * Shard in a {@link SolrCollection}, i.e. a subset of the data indexed in that collection. + */ +public interface Shard { + /** + * 0 numbered index of the {@link Shard} in the {@link SolrCollection}. + */ + int getShardIndex(); Review comment: We really need a name here - shards can have arbitrary names. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
