murblanc commented on a change in pull request #1678:
URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r455999179
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/assign/policy8x/AssignerCloudManager.java
##########
@@ -0,0 +1,81 @@
+package org.apache.solr.cloud.api.collections.assign.policy8x;
+
+import java.io.IOException;
+import java.util.Map;
+
+import org.apache.solr.client.solrj.SolrRequest;
+import org.apache.solr.client.solrj.SolrResponse;
+import org.apache.solr.client.solrj.cloud.DistribStateManager;
+import org.apache.solr.client.solrj.cloud.DistributedQueueFactory;
+import org.apache.solr.client.solrj.cloud.NodeStateProvider;
+import org.apache.solr.client.solrj.cloud.SolrCloudManager;
+import org.apache.solr.client.solrj.impl.ClusterStateProvider;
+import org.apache.solr.cloud.api.collections.assign.AssignerClusterState;
+import org.apache.solr.common.util.ObjectCache;
+import org.apache.solr.common.util.TimeSource;
+
+/**
+ *
+ */
+public class AssignerCloudManager implements SolrCloudManager {
+ private final ObjectCache objectCache = new ObjectCache();
+ private final TimeSource timeSource;
+ private final AssignerClusterState assignerClusterState;
+ private final AssignerClusterStateProvider clusterStateProvider;
+ private final AssignerNodeStateProvider nodeStateProvider;
+ private final AssignerDistribStateManager distribStateManager;
+
+ public AssignerCloudManager(AssignerClusterState assignerClusterState,
Review comment:
I don't get the logic. I'm assuming package `*.policy8x` is internal. It
should not depend on state as seen by the plugins but should **build** that
state based on internal SolrCloud state.
Here and in other classes in this package I have the impression we do things
the wrong way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
