murblanc commented on a change in pull request #1678: URL: https://github.com/apache/lucene-solr/pull/1678#discussion_r455987321
########## File path: solr/core/src/java/org/apache/solr/cloud/api/collections/assign/AssignDecisions.java ########## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.solr.cloud.api.collections.assign; + +import java.util.Collection; + +/** + * + */ +public class AssignDecisions { + + private final AssignerClusterState outputClusterState; + private final Collection<AssignDecision> decisions; + + public AssignDecisions(AssignerClusterState outputClusterState, Collection<AssignDecision> decisions) { Review comment: The Solr side support framework (didn't read all classes yet) might want to apply the decisions to another cluster state maintained centrally, used as a "master copy" including all changes from all computations and passed (in an immutable form so the plugin doesn't become crazy) to the next computation. Internally we don't have to make copies of everything, we can share data but give consistent point in time reads. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
