[ 
https://issues.apache.org/jira/browse/SOLR-14435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158101#comment-17158101
 ] 

David Eric Pugh commented on SOLR-14435:
----------------------------------------

Thanks [~asalamon74], and I'm pinging [~ctargett] because while the patch is 
technically correct, those parameters do make sense to be added, I wonder if we 
are headed to an issue on the page where we are copying the details about the 
individual parameters over a wide variety of commands?  

Do you see in the details for the REINDEXCOLLECTION we highlight the extra 
parameters and reference back to the CREATE command?   Should we do that for 
the RESTORE command?  And then maybe call out "Note: For the createNodeSet 
command the special parameter EMPTY is not supported", and do that for any 
other command that has a special case?  

I really like the patch in terms of getting completeness of coverage of all the 
parameters, that helps instill confidence and helps you understand which 
commands are closely related to each other ;-)

> createNodeSet and createNodeSet.shuffle parameters missing from Collection 
> Restore RefGuide
> -------------------------------------------------------------------------------------------
>
>                 Key: SOLR-14435
>                 URL: https://issues.apache.org/jira/browse/SOLR-14435
>             Project: Solr
>          Issue Type: Improvement
>          Components: documentation
>            Reporter: Andras Salamon
>            Assignee: David Eric Pugh
>            Priority: Minor
>         Attachments: SOLR-14435-01.patch
>
>
> Although {{createNodeSet}} and {{createNodeSet.shuffle}} parameters are 
> supported by the Collection RESTORE command (I've tested it), they are 
> missing from the documentation:
> [https://lucene.apache.org/solr/guide/8_5/collection-management.html#collection-management]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to