dsmiley commented on a change in pull request #1572:
URL: https://github.com/apache/lucene-solr/pull/1572#discussion_r439789761
##########
File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java
##########
@@ -338,6 +339,19 @@ public CoreContainer(NodeConfig config, CoresLocator
locator, boolean asyncSolrC
ExecutorUtil.newMDCAwareCachedThreadPool(
cfg.getReplayUpdatesThreads(),
new SolrNamedThreadFactory("replayUpdatesExecutor")));
+
+ this.allowPaths = new java.util.HashSet<>();
+ this.allowPaths.add(cfg.getSolrHome().toAbsolutePath());
Review comment:
paths in cfg are already absolute -- thanks to me recently :-)
##########
File path: solr/core/src/test-files/solr/solr-50-all.xml
##########
@@ -24,6 +24,7 @@
<str name="configSetsHandler">testConfigSetsHandler</str>
<str name="managementPath">testManagementPath</str>
<str name="sharedLib">testSharedLib</str>
+ <str name="allowPaths">/tmp,/home/john</str>
Review comment:
Since this file is a NamedList, shouldn't we be using `<arr` for an
array of strings?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
