mikemccand commented on a change in pull request #1552:
URL: https://github.com/apache/lucene-solr/pull/1552#discussion_r435592460



##########
File path: lucene/CHANGES.txt
##########
@@ -376,6 +376,8 @@ Improvements
 
 * LUCENE-9253: KoreanTokenizer now supports custom dictionaries(system, 
unknown). (Namgyu Kim)
 
+* LUCENE-8962: Add ability to selectively merge on commit (Michael Froh)

Review comment:
       Maybe `Add IndexWriter merge-on-commit feature to selectively merge 
small segments on commit, subject to a configurable timeout, to improve search 
performance by reducing the number of small segments for searching`?

##########
File path: lucene/core/src/java/org/apache/lucene/index/IndexWriterConfig.java
##########
@@ -459,6 +463,31 @@ public IndexWriterConfig setCommitOnClose(boolean 
commitOnClose) {
     return this;
   }
 
+  /**
+   * Expert: sets the amount of time to wait for merges returned by 
MergePolicy.findFullFlushMerges(...).
+   * If this time is reached, we proceed with the commit based on segments 
merged up to that point.
+   * The merges are not cancelled, and may still run to completion independent 
of the commit.

Review comment:
       Maybe for the last sentence: `The merges are not cancelled, and will 
still run to completion independent of the commit like normal segment merges`?
   
   Maybe also state that this setting has no effect unless the `MergePolicy` 
actually returns merges from `findFullFlushMerges`, which the default merge 
policy does not?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to