[
https://issues.apache.org/jira/browse/LUCENE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099577#comment-17099577
]
Mikhail Khludnev commented on LUCENE-9360:
------------------------------------------
Turns out it's necessary, because
https://issues.apache.org/jira/secure/attachment/13002026/LUCENE-9328.patch
fails
https://builds.apache.org/job/PreCommit-LUCENE-Build/268/artifact/out/patch-unit-solr_core.txt
{code}
[junit4] Suite: org.apache.solr.search.grouping.AllGroupHeadsCollectorTest
[junit4] 2> 4047854 INFO
(SUITE-AllGroupHeadsCollectorTest-seed#[A8E569347CC3E5CE]-worker) [ ]
o.a.s.SolrTestCase Setting 'solr.default.confdir' system property to
test-framework derived value of
'/home/jenkins/jenkins-slave/workspace/PreCommit-LUCENE-Build/sourcedir/solr/server/solr/configsets/_default/conf'
[junit4] 2> NOTE: reproduce with: ant test
-Dtestcase=AllGroupHeadsCollectorTest -Dtests.method=testBasicBlockJoin
-Dtests.seed=A8E569347CC3E5CE -Dtests.multiplier=2 -Dtests.slow=true
-Dtests.locale=pa-Guru-IN -Dtests.timezone=Antarctica/South_Pole
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
[junit4] FAILURE 0.12s J0 | AllGroupHeadsCollectorTest.testBasicBlockJoin <<<
[junit4] > Throwable #1: java.lang.AssertionError
[junit4] > at
__randomizedtesting.SeedInfo.seed([A8E569347CC3E5CE:9E22703862079502]:0)
[junit4] > at
org.apache.lucene.index.AssertingLeafReader$AssertingSortedDocValues.advance(AssertingLeafReader.java:757)
[junit4] > at
org.apache.lucene.search.grouping.DocValuesPoolingReader$1.advance(DocValuesPoolingReader.java:127)
[junit4] > at
org.apache.lucene.search.SortedSetSelector$MaxValue.advance(SortedSetSelector.java:186)
[junit4] > at
org.apache.lucene.search.ConjunctionDISI.doNext(ConjunctionDISI.java:200)
[junit4] > at
org.apache.lucene.search.ConjunctionDISI.advance(ConjunctionDISI.java:230)
[junit4] > at
org.apache.lucene.search.join.ToParentDocValues.advanceExact(ToParentDocValues.java:259)
[junit4] > at
org.apache.lucene.search.join.ToParentDocValues$SortedDVs.advanceExact(ToParentDocValues.java:84)
[junit4] > at
org.apache.lucene.search.FieldComparator$TermOrdValComparator.getOrdForDoc(FieldComparator.java:643)
[junit4] > at
org.apache.lucene.search.FieldComparator$TermOrdValComparator.copy(FieldComparator.java:691)
[junit4] > at
org.apache.lucene.search.grouping.AllGroupHeadsCollector$SortingGroupHead.<init>(AllGroupHeadsCollector.java:278)
[junit4] > at
org.apache.lucene.search.grouping.AllGroupHeadsCollector$SortingGroupHeadsCollector.newGroupHead(AllGroupHeadsCollector.java:260)
[junit4] > at
org.apache.lucene.search.grouping.AllGroupHeadsCollector.collect(AllGroupHeadsCollector.java:137)
[junit4] > at
org.apache.lucene.search.AssertingLeafCollector.collect(AssertingLeafCollector.java:49)
[junit4] > at
org.apache.lucene.search.AssertingCollector$1.collect(AssertingCollector.java:58)
[junit4] > at
org.apache.lucene.search.AssertingLeafCollector.collect(AssertingLeafCollector.java:49)
[junit4] > at
org.apache.lucene.search.AssertingLeafCollector.collect(AssertingLeafCollector.java:49)
[junit4] > at
org.apache.lucene.search.Weight$DefaultBulkScorer.scoreAll(Weight.java:254)
[junit4] > at
org.apache.lucene.search.Weight$DefaultBulkScorer.score(Weight.java:205)
[junit4] > at
org.apache.lucene.search.AssertingBulkScorer.score(AssertingBulkScorer.java:81)
[junit4] > at
org.apache.lucene.search.AssertingBulkScorer.score(AssertingBulkScorer.java:65)
[junit4] > at
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:741)
[junit4] > at
org.apache.lucene.search.AssertingIndexSearcher.search(AssertingIndexSearcher.java:72)
[junit4] > at
org.apache.lucene.search.IndexSearcher.search(IndexSearcher.java:528)
[junit4] > at
org.apache.solr.search.grouping.AllGroupHeadsCollectorTest.testBasicBlockJoin(AllGroupHeadsCollectorTest.java:150)
{code}
I'll check whether earlier fix with {{advanceExact()}} can heal it.
> NOT NEEDED. ToParentDocValues uses advanceExact() of underneath DocValues
> -------------------------------------------------------------------------
>
> Key: LUCENE-9360
> URL: https://issues.apache.org/jira/browse/LUCENE-9360
> Project: Lucene - Core
> Issue Type: Sub-task
> Reporter: Mikhail Khludnev
> Priority: Major
>
> Currently {{ToParentDocvalues.advanceExact()}} propagates it to
> {{DocValues.advance()}} as advised at LUCENE-7871. It causes some problem at
> LUCENE-9328 and seems not really reasonable. The later jira has patch
> attached which resolves this. The questions is why(not)?
> cc [~jpountz]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
