mkhludnev commented on a change in pull request #1462:
URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419010654
##########
File path:
lucene/test-framework/src/java/org/apache/lucene/codecs/asserting/AssertingDocValuesFormat.java
##########
@@ -285,7 +286,9 @@ public SortedSetDocValues getSortedSet(FieldInfo field)
throws IOException {
assert field.getDocValuesType() == DocValuesType.SORTED_SET;
SortedSetDocValues values = in.getSortedSet(field);
assert values != null;
- return new AssertingLeafReader.AssertingSortedSetDocValues(values,
maxDoc);
+ final SortedDocValues singleton = DocValues.unwrapSingleton(values);
+ return singleton==null ? new
AssertingLeafReader.AssertingSortedSetDocValues(values, maxDoc) :
Review comment:
I think it's worth to span this to NumericsSet and also to other usages
AssertingDV. Now, these DVs aren't handled by `DocValues.unwrapSingleton()`.
@romseygeek , isn't it worth to commit separately?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
