mkhludnev commented on a change in pull request #1462:
URL: https://github.com/apache/lucene-solr/pull/1462#discussion_r419010400



##########
File path: 
lucene/join/src/java/org/apache/lucene/search/join/BlockJoinSelector.java
##########
@@ -112,9 +112,9 @@ public static SortedDocValues wrap(final SortedDocValues 
values, Type selection,
    *  one value per parent among its {@code children} using the configured
    *  {@code selection} type. */
   public static SortedDocValues wrap(final SortedDocValues values, Type 
selection, BitSet parents, DocIdSetIterator children) {
-    if (values.docID() != -1) {
-      throw new IllegalArgumentException("values iterator was already 
consumed: values.docID=" + values.docID());
-    }
+    //if (values.docID() != -1) {

Review comment:
       Would be discussed later, if all other issues resolved. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to