romseygeek commented on pull request #1461: URL: https://github.com/apache/lucene-solr/pull/1461#issuecomment-620093446
cc @martijnvg @dsmiley We should be able to remove `AllGroupHeadsCollectorTest`, `AllGroupsCollectorTest` and `GroupingSearchTest` once this is merged, and possibly `TestGrouping` as well. It should also make it much easier to add groupers based on Double/LongValuesSource, with the aim of moving the `ValueSourceGroupSelector` into Solr and deprecating ValueSource within lucene. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
